MM-59410 - Adding dim_server_info to the "Feature usage" explore#1020
Open
catalintomai wants to merge 1 commit intomasterfrom
Open
MM-59410 - Adding dim_server_info to the "Feature usage" explore#1020catalintomai wants to merge 1 commit intomasterfrom
catalintomai wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Adding a sanity check for this: mattermost/mattermost-data-warehouse#1559. Let's resolve any issues and we can follow up on this PR. |
catalintomai
added
the
Do Not Merge
|
GIthub clean up (long outstanding PRs) - would it make sense to either close or move to Draft? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding join to the
dim_server_infoview to the "Feature Usage" explore. The reason is to help implement MM-59410, to use the "hosting type" to be able to display either cloud or self-hosted customer info, depending on the server type. Technically, there should be no need for that right now, the cloud installs have the full set of features, but could not find any other explore that would make sense to use in the context of MM-59410.Other options would be to create a separate explore for MM-59410 and alike or to use smth. like
rpt_active_user_base(which coalesces cloud and self-hosted customer metadata and is the only explore that uses the latest customer info -dim_latest_server_customer_info).Ticket Link
https://mattermost.atlassian.net/browse/MM-59410